Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disabling of SSL verification #46

Open
schnelle opened this issue Jan 29, 2024 · 0 comments
Open

Remove disabling of SSL verification #46

schnelle opened this issue Jan 29, 2024 · 0 comments
Assignees
@schnelle
Labels
reference implementation

Comments

@schnelle
Copy link
Collaborator

schnelle commented Jan 29, 2024 •
edited
Loading

The current code to ChatGPT uses a secure connection. However, SSL verification has been disabled in CURL for now. This should not be the case in the final code.

See

voiceinteraction/source/w3cipa/sources/w3c/voiceinteraction/ipa/external/ipa/chatgpt/ChatGPTAdapter.cpp

Lines 124 to 126 in 4d203de

// TODO Remove this disabling of SSL verification
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);

schnelle added a commit that referenced this issue Jan 13, 2025
@schnelle
issue #46 Add model field and SSL verification to ChatGPTIPAProvider
3d46446 
- Updated .gitignore to include cacert.pem in the source directory.
- Added instructions in SOURCE.md to download cacert.pem.
- Modified CMakeLists.txt to copy cacert.pem to the config directory.
- Updated ChatGPTIPAProvider.json to include a new model field.
- Added model field to ChatGPTConfiguration struct and parsing logic.
- Added model field to ChatGPTIPAProvider class.
- Updated ChatGPTIPAProvider::initialize to read model from config.
- Modified ChatGPTIPAProvider::processInput to use model from config.
- Enabled SSL verification in processInput using cacert.pem.
schnelle added a commit that referenced this issue Jan 13, 2025
@schnelle
issue #46 Automate cacert.pem download in CMakeLists.txt
22d5cde 
Automated the download of `cacert.pem` in `CMakeLists.txt` using `file(DOWNLOAD ...)`, removing manual instructions from `SOURCE.md`. Cleaned up `CMakeLists.txt` by removing outdated comments and license information. Updated `configure_file` and `install` commands to use and include `cacert.pem`. Added `<fstream>` header in `ChatGPTIPAProvider.cpp` for file operations.
@schnelle schnelle self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schnelle schnelle

Labels
reference implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schnelle