-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyphenation doesn't work on local installation #551
Comments
Maybe related to microsoft/playwright#34067? |
This is a known issue: |
Thanks,
is there any workaround? How does the viewer on the demo instance does this?
Am 10. Januar 2025 07:17:18 MEZ schrieb Shinyu Murakami ***@***.***>:
…This is a known issue:
- vivliostyle/vivliostyle.js#569
--
Reply to this email directly or view it on GitHub:
#551 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Chromium got a new headless mode, it should be fixed: https://issues.chromium.org/issues/40257759
Maybe the issue is the missing chromium profile? |
According to this issue's comments, Playwright v1.49 has Vivliostyle CLI uses the same Chromium (normal |
Since playwright does'nt seem to intend fixing the issue (but instead removing hyphen-data for the headless_shell), is it possible to build a workaround? Could we modify the playwright chrome installation / give the vivliostyle-cli users the options to include hyphen-data?
Am 11. Januar 2025 03:38:00 MEZ schrieb Shinyu Murakami ***@***.***>:
…> Maybe related to [microsoft/playwright#34067](microsoft/playwright#34067)?
According to this issue's comments, Playwright v1.49 has `hyphen-data` for the `headless_shell` (equivalent to the old headless mode) and hyphenation works in the `headless_shell` but does not work in normal `chrome`.
Vivliostyle CLI uses the same Chromium (normal `chrome`) for both preview (headed mode) and build (headless mode) commands (See: #545 and #547). So hyphenation does not work on both commands (except on macOS where Chromium uses macOS's hyphenation).
--
Reply to this email directly or view it on GitHub:
#551 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Switching Playwright to Puppeteer might be a solution of this problem. Puppeteer uses Chrome for Testing which includes hyphen-data. I've tested Puppeteer on Windows and confirmed that hyphenation is working. |
Hey,
I can't get working hyphenation of a german html page with vivliostyle-cli. Weirdly, it does work on the Demo Viewer: https://vivliostyle.org/viewer/#src=https://gist.github.com/anghenfil/4a7635e45c900e636561d93756ac0b66 but not on my local (archlinux) system (neither with the viewer nor the pdf from vivliostyle build).
I already tried to use --executable-browser with the path to my local chromium installation (where it does work when I view the HTML with chromium directly), but once I use vivliostyle (either viewer or via build) the hyphenation stops working.
For the demo HTML see https://gist.github.com/anghenfil/4a7635e45c900e636561d93756ac0b66.
I also tried a fresh ubuntu docker container, but hyphenation didn't work either.
Any ideas?
Best anghenfil
The text was updated successfully, but these errors were encountered: