Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

radio and checkbox classes affects other inputs too #654

Open
bschaeublin opened this issue Feb 25, 2019 · 1 comment
Open

radio and checkbox classes affects other inputs too #654

bschaeublin opened this issue Feb 25, 2019 · 1 comment
Labels
4.0-candidate fixed with MD This issue will very likely be fixed with the Material design migration

Comments

@bschaeublin
Copy link

bschaeublin commented Feb 25, 2019

When having a <input type="text"> nested under a <input type="radio"
the "input constraint" at following classes:

  • radio--left
  • radio--right
    are affecting the nested text inputs "top" attribute (and some more), which causes the input field to be higher as the label.

The same problem exists within checkbox classes:

  • checkbox--left
  • checkbox--right

I'll make a PR, that adds a constraint to the input class to:

  • input[type=radio] at radios.scss
  • input[type=checkbox] at checkboxes.scss
    as this would be more specific, which controls that we really want to be affected by the class.

example:
image

@gillerr
Copy link
Contributor

gillerr commented Sep 10, 2019

Will be fixed with Material Design Migration.
Issue will be closed

@gillerr gillerr added the fixed with MD This issue will very likely be fixed with the Material design migration label Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4.0-candidate fixed with MD This issue will very likely be fixed with the Material design migration
Projects
None yet
Development

No branches or pull requests

2 participants