-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docs with fresh CPython commit not ~24h old one #190
Comments
This was referenced Aug 25, 2024
It might also make sense to reverse the order of builds so that the newest releases (where there is the most immediate interest and churn) will be built first. |
They're already being run in reverse: diff --git a/build_docs.py b/build_docs.py
index 93dcac4..1756c2b 100755
--- a/build_docs.py
+++ b/build_docs.py
@@ -1117,7 +1117,7 @@ def build_docs(args) -> bool:
cpython_repo = Repository(
"https://github.com/python/cpython.git", args.build_root / "cpython"
)
- cpython_repo.update()
+ # cpython_repo.update()
while todo:
version, language = todo.pop()
logging.root.handlers[0].setFormatter(
@@ -1125,6 +1125,8 @@ def build_docs(args) -> bool:
f"%(asctime)s %(levelname)s {language.tag}/{version.name}: %(message)s"
)
)
+ print(f"{version.name}/{language.tag}")
+ continue
if sentry_sdk:
with sentry_sdk.configure_scope() as scope:
scope.set_tag("version", version.name)
@@ -1136,6 +1138,7 @@ def build_docs(args) -> bool:
logging.root.handlers[0].setFormatter(
logging.Formatter("%(asctime)s %(levelname)s: %(message)s")
)
+ sys.exit()
build_sitemap(versions, languages, args.www_root, args.group)
build_404(args.www_root, args.group)
It's because we sort the versions from lowest to highest, but then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A full build of all languages / versions has been taking somewhere between 24 and 50 hours (#169, but python/cpython#123113 should cut about a third).
We update the CPython repo once at the start, then loop each language/version combo:
docsbuild-scripts/build_docs.py
Lines 1120 to 1135 in 56d72d4
This means builds near the end of the loop will be using a Git commit which could be a day or two old.
For example, looking at the current logs:
It's currently 2024-08-25 10:45, meaning current builds are using an 18-hour-old commit, and we're about half way through a full build.
So let's instead update the CPython repo before each language/version, perhaps by moving the update inside the
while
loop:The text was updated successfully, but these errors were encountered: