Make new resolver process Requires-Python before other dependencies #13160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
added
C: dependency resolution
Co-authored-by: Tzu-ping Chung <[email protected]>
This avoid an explicit requirement (name @ url) from being prepared too eagerly when its metadata is not required. Co-authored-by: Richard Si <[email protected]>
This makes the resolver always inspect Requires-Python first when checking a candidate's consistency, ensuring that no other candidates are prepared if the Requires-Python check fails. Co-authored-by: Richard Si <[email protected]>
ichard26
force-pushed
the
bug/requires-python
branch
from
8362096 to
b3b468f
Compare
|
Ah, other tests are failing. That's why this was a draft earlier. Will take a look sometime later. |
|
Was this rebased on |
|
A little out of date, but new enough where the test suite is up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revived version of #11398.
Closes #11398.
Fixes #13146.
Fixes #11142.