Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When hovering over an avatar, do not only display local time but also calculate the time difference compared to you (similar to how GitHub does this) #48626

Open
Tracked by #43763
sorbaugh opened this issue Oct 9, 2024 · 8 comments · May be fixed by #50214

Comments

@sorbaugh
Copy link
Contributor

sorbaugh commented Oct 9, 2024

Subtask: #43763

@sorbaugh
Copy link
Contributor Author

sorbaugh commented Oct 9, 2024

cc @nickvergessen something that is relevant for Talk too?

@nickvergessen
Copy link
Member

Will automatically appear in Talk if modified correctly in the LocalTimeProvider

@sorbaugh
Copy link
Contributor Author

Notes:

  • Might need backend work. Judging from nickvergessen's comment this would require "only" a change in one line of code but needs to be tested.
  • We need to improve the user popup a bit. There's additional data that could be added. Consensus is generally the user popup could use some love.

@marcoambrosini marcoambrosini moved this to 🏗️ At engineering in 🖍 Design team Oct 11, 2024
@marcoambrosini marcoambrosini self-assigned this Oct 11, 2024
@sorbaugh sorbaugh moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📁 Files team Dec 2, 2024
@sorbaugh
Copy link
Contributor Author

sorbaugh commented Dec 2, 2024

@marcoambrosini our assumption would be something like displaying "Local time: 9:41 AM (3 hours behind)", "Local time: 9:41 AM (2 hours ahead)"

We're not sure yet. Wdyt?

Image

@marcoambrosini
Copy link
Member

I think that works, and we should put that in a new line

@sorbaugh
Copy link
Contributor Author

sorbaugh commented Dec 2, 2024

I think that works, and we should put that in a new line

cc @yemkareems

@susnux
Copy link
Contributor

susnux commented Jan 16, 2025

Question: Is the "Local time:" part required?
Github only uses the icon + local time + offset like:

🕐 15:24 - 9h30m ahead

This would fit into one line without breaking the layout

@susnux
Copy link
Contributor

susnux commented Jan 16, 2025

If we prefer to keep it we maybe should think about allowing the API to pass a second line so we end up with:

🕐 Local time: 15:24
   3 hours ahead

(or if 12h format was chosen)

🕐 Local time: 9:30 AM
   2 hours behind

@susnux susnux self-assigned this Jan 16, 2025
@susnux susnux added the 3. to review Waiting for reviews label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Status: 🏗️ At engineering
Development

Successfully merging a pull request may close this issue.

5 participants