Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal curvy underlines don't look as bright as other underline styles #158979

Open
TylerLeonhardt-alt opened this issue Aug 23, 2022 · 2 comments
Open

Terminal curvy underlines don't look as bright as other underline styles #158979

TylerLeonhardt-alt opened this issue Aug 23, 2022 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
Backlog

Comments

@TylerLeonhardt-alt
Copy link

Testing #158827

The curvy line seems darker than the straight line. Is that expected?
image

This is @TylerLeonhardt's alt
@weinand weinand assigned meganrogge and Tyriar and unassigned weinand Aug 23, 2022
@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

I had a bit of trouble making the curvy line look good at all zoom levels, we can have a more targeted look at fixing it as I want trying to make everything work when I last looked.

@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

Upstream: xtermjs/xterm.js#4064

@Tyriar Tyriar mentioned this issue Aug 23, 2022
Open
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-rendering labels Aug 23, 2022
@Tyriar Tyriar added this to the Backlog milestone Aug 23, 2022
@meganrogge meganrogge removed their assignment Dec 5, 2022
@Tyriar Tyriar changed the title Why is curvy muted? Terminal curvy underlines don't look as bright as other underline styles Dec 8, 2022
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@weinand @Tyriar @meganrogge @TylerLeonhardt-alt @vscodenpa