Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_commit_id.h should be ASCII not UTF-16LE #4134

Open
dthaler opened this issue Jan 13, 2025 · 0 comments
Open

git_commit_id.h should be ASCII not UTF-16LE #4134

dthaler opened this issue Jan 13, 2025 · 0 comments
Assignees
Labels
cleanup Affects API usability or code maintainability but not correctness or applicability P2 triaged Discussed in a triage meeting
Milestone

Comments

@dthaler
Copy link
Collaborator

dthaler commented Jan 13, 2025

Describe the bug

Header files should be ASCII not UTF-16LE.

For example, format-code.ps1 on git_commit_id.h reports:
error: encoding with unsupported byte order mark "UTF-16 (LE)" detected in file 'include\git_commit_id.h'.

OS information

No response

Steps taken to reproduce bug

Run the format_code or do any hexdump of git_commit_id.h, or just do "vim -b git_commit_id.h"

Expected behavior

File should be ASCII

Actual outcome

File is UTF-16LE

Additional details

No response

@dthaler dthaler added the cleanup Affects API usability or code maintainability but not correctness or applicability label Jan 13, 2025
@shankarseal shankarseal self-assigned this Jan 13, 2025
@shankarseal shankarseal added P2 triaged Discussed in a triage meeting labels Jan 13, 2025
@shankarseal shankarseal added this to the 2501 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Affects API usability or code maintainability but not correctness or applicability P2 triaged Discussed in a triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants