Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Improve Det Id tremtent #279

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

breaking: Improve Det Id tremtent #279

wants to merge 2 commits into from

Conversation

KSkwarczynski
Copy link
Member

@KSkwarczynski KSkwarczynski commented Jan 9, 2025 •
edited
Loading

Pull request description

See also: mach3-software/MaCh3Tutorial#71

Instead of hardcoded names let's have string:det id

Sample PDF can only have 1 string, and no wildcards

However now each syst can have several "det ids" to which applies"
For example *DetID: ["Tutorial "] or **DetID: ["Tutorial ", "Blarb "]

In addition now DetId applies to Osc params. For example delta CP will aply to all but baseline only to beam.
You can see in this example that parameters with *DetID: ["Tutorial "]

Found 3 for Tutorial Beam Params of type Norm
Found 5 for Tutorial Beam Params of type Spline
Found 4 for Tutorial Beam Params of type Functional
Found 3 for Tutorial Beam From GetNormParsFromDetID
Found 3 for Tutorial ATM Params of type Norm
Found 5 for Tutorial ATM Params of type Spline
Found 4 for Tutorial ATM Params of type Functional
Found 3 for Tutorial ATM From GetNormParsFromDetID
Found 3 for tutorial beam Params of type Norm
Found 5 for tutorial beam Params of type Spline
Found 4 for tutorial beam Params of type Functional
Found 3 for tutorial beam From GetNormParsFromDetID
Found 0 for blarbATM Params of type Norm
Found 0 for blarbATM Params of type Spline
Found 0 for blarbATM Params of type Functional
Found 0 for blarbATM From GetNormParsFromDetID

Changes or fixes

Examples

CovOsc CovModel

@KSkwarczynski KSkwarczynski self-assigned this Jan 9, 2025
@github-actions github-actions bot added Documentation Improvements or additions to documentation Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples Cmake labels Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@KSkwarczynski KSkwarczynski mentioned this pull request Jan 9, 2025
Open
@KSkwarczynski KSkwarczynski linked an issue Jan 9, 2025 that may be closed by this pull request
Replace DetID with a 'samples' cut in the parameter yaml that lets you have a parameter only apply to samplePDF objects with a matching name #192
Open
@pjdunne
Copy link
Collaborator

pjdunne commented Jan 9, 2025

We should maybe remove the sample detid tag and just use the sample name

@KSkwarczynski KSkwarczynski mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdAtkin EdAtkin Awaiting requested review from EdAtkin EdAtkin is a code owner

@dbarrow257 dbarrow257 Awaiting requested review from dbarrow257 dbarrow257 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@KSkwarczynski KSkwarczynski

Labels
Cmake Documentation Improvements or additions to documentation Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples
Projects
None yet
Milestone
No milestone
2 participants
@KSkwarczynski @pjdunne