You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes PR related to package updates/version bumps break snuba admin. For example, this PR deals with replacing python-jose with pyjwt to fix security vulnerabilities. But it broke snuba admin and it was unavailable for a few hours. Only after the PR is reverted and a release went out, snuba admin came back up. Interestingly, the culprit PR passed CI and unit tests both. See the success of CI pipeline after the PR was merged initially in this screenshot. This raises the question on the test coverage of snuba admin.
Investigate and add unit/functional tests to safeguard Snuba admin from such breakages in the future.
Expected Result
Unit tests/ functional tests should have caught that offending change breaks snuba admin.
Actual Result
The unit tests and CI tests pass successfully, leaving no way for the reviewer/implementor to determine the side-effects of the change.
The text was updated successfully, but these errors were encountered:
Environment
Snuba admin
Steps to Reproduce
Sometimes PR related to package updates/version bumps break snuba admin. For example, this PR deals with replacing python-jose with pyjwt to fix security vulnerabilities. But it broke snuba admin and it was unavailable for a few hours. Only after the PR is reverted and a release went out, snuba admin came back up. Interestingly, the culprit PR passed CI and unit tests both. See the success of CI pipeline after the PR was merged initially in this screenshot. This raises the question on the test coverage of snuba admin.
Investigate and add unit/functional tests to safeguard Snuba admin from such breakages in the future.
Expected Result
Unit tests/ functional tests should have caught that offending change breaks snuba admin.
Actual Result
The unit tests and CI tests pass successfully, leaving no way for the reviewer/implementor to determine the side-effects of the change.
The text was updated successfully, but these errors were encountered: