Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and add unit tests or functional tests to detect Snuba admin breakage #6749

Open
onkar opened this issue Jan 10, 2025 · 0 comments

Comments

@onkar
Copy link
Member

onkar commented Jan 10, 2025

Environment

Snuba admin

Steps to Reproduce

Sometimes PR related to package updates/version bumps break snuba admin. For example, this PR deals with replacing python-jose with pyjwt to fix security vulnerabilities. But it broke snuba admin and it was unavailable for a few hours. Only after the PR is reverted and a release went out, snuba admin came back up. Interestingly, the culprit PR passed CI and unit tests both. See the success of CI pipeline after the PR was merged initially in this screenshot. This raises the question on the test coverage of snuba admin.

Image

Investigate and add unit/functional tests to safeguard Snuba admin from such breakages in the future.

Expected Result

Unit tests/ functional tests should have caught that offending change breaks snuba admin.

Actual Result

The unit tests and CI tests pass successfully, leaving no way for the reviewer/implementor to determine the side-effects of the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant