Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between formatting and code-quality rules #13397

Closed
pubmikeb opened this issue Jun 6, 2020 · 3 comments
Closed

Distinguish between formatting and code-quality rules #13397

pubmikeb opened this issue Jun 6, 2020 · 3 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint website Relates to ESLint's website at eslint.github.io

Comments

@pubmikeb
Copy link

pubmikeb commented Jun 6, 2020

The version of ESLint you are using.
7.2.0

The problem you want to solve.
Following the issue #13348, currently Rules Configuration tool contains a long mixed list of rules, which contains both formatting and code-quality rules all together.

Your take on the correct solution to problem.
It's better to separate these rules into two categories:

  • formatting rules
  • code-quality rules

This will simplify the rules management and housekeeping, and will allow easily to delegate code-quality linting to ESLint and rely on Prettier for formatting tasks.

Are you willing to submit a pull request to implement this change?
No.

@pubmikeb pubmikeb added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon labels Jun 6, 2020
@kaicataldo
Copy link
Member

Agreed that the demo could use a lot of love. Could you make this issue in https://github.com/eslint/website, since that's where this code lives?

@kaicataldo kaicataldo added website Relates to ESLint's website at eslint.github.io and removed triage An ESLint team member will look at this issue soon core Relates to ESLint's core APIs and features labels Jun 6, 2020
@pubmikeb
Copy link
Author

pubmikeb commented Jun 6, 2020

Done: eslint/archive-website#736

Perhaps, it worths to mention https://github.com/eslint/website for the website related issues in the Issue Creation Wizard?

@kaicataldo
Copy link
Member

Thanks! I'll go ahead and close this in favor of the other issue.

Perhaps, it worths to mention https://github.com/eslint/website for the website related issues in the Issue Creation Wizard?

Great idea!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 4, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint website Relates to ESLint's website at eslint.github.io
Projects
None yet
Development

No branches or pull requests

2 participants