Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP1002 AssemblySymbolLoader warning needs more information #46093

Open
ViktorHofer opened this issue Jan 17, 2025 · 1 comment · May be fixed by #46102
Open

CP1002 AssemblySymbolLoader warning needs more information #46093

ViktorHofer opened this issue Jan 17, 2025 · 1 comment · May be fixed by #46102
Assignees
@ViktorHofer
Labels
Area-ApiCompat

Comments

@ViktorHofer
Copy link
Member 

D:\a\_work\1\s\.dotnet\sdk\10.0.100-alpha.1.25067.4\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP1002: Could not resolve reference 'Microsoft.NET.StringTools.dll' in any of the provided search directories. [D:\a\_work\1\s\src\SignalR\common\Protocols.MessagePack\src\Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj]
D:\a\_work\1\s\.dotnet\sdk\10.0.100-alpha.1.25067.4\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP1002: Could not resolve reference 'Microsoft.NET.StringTools.dll' in any of the provided search directories. [D:\a\_work\1\s\src\SignalR\common\Protocols.MessagePack\src\Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj]
D:\a\_work\1\s\.dotnet\sdk\10.0.100-alpha.1.25067.4\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP1002: Could not resolve reference 'Microsoft.NET.StringTools.dll' in any of the provided search directories. [D:\a\_work\1\s\src\SignalR\common\Protocols.MessagePack\src\Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj]

A few issues:

  1. The warning message should mention why it gets loaded, which other assembly brings it in.
  2. The warning message can get logged multiple times if multiple assemblies in a package have a reference to it. Maybe the message could include the root assembly (including its relative path) that gets loaded.
  3. It would be good to log all assemblies that get loaded by the AssemblySymbolLoader with low importance so that the information appears in a binlog.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels Jan 17, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

@dotnet/area-infrastructure-libraries a new issue has been filed in the ApiCompat area, please triage

@ViktorHofer ViktorHofer self-assigned this Jan 17, 2025
@ViktorHofer ViktorHofer removed the untriaged Request triage from a team member label Jan 17, 2025
@ViktorHofer ViktorHofer linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorHofer ViktorHofer

Labels
Area-ApiCompat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve AssemblySymbolLoader logging dotnet/sdk
1 participant
@ViktorHofer