Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Detail Summary" from binary logger #11244

Open
yuehuang010 opened this issue Jan 9, 2025 · 0 comments
Open

Remove "Detail Summary" from binary logger #11244

yuehuang010 opened this issue Jan 9, 2025 · 0 comments
Labels
changewaves help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. Priority:2 Work that is important, but not critical for the release triaged

Comments

@yuehuang010
Copy link
Contributor

Summary

When logging with binary logger, a section of the binlog is dedicated to storing Detail Summary. The Detail Summary is an ascii graph representing the build timeline. However, it is possible to reconstruct the graph with greater fidelity.

Background and Motivation

Size msbuild.exe /bl msbuild.exe /bl /ds:false difference
Mid size solution 34,910,977 bytes 33,710,811 bytes 3% reduction
Large size solution 94,076,308 bytes 87,592,988 bytes 7.4% reduction

In our CI system, the binary logs are kept for a long time so the total space saving can easily add up.

Proposed Feature

When using the switch /bl, it will enable Detail Summary by default. The propose change is to set the behavior to be off by default.

Alternative Designs

No response

@maridematte maridematte added Priority:2 Work that is important, but not critical for the release changewaves triaged help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changewaves help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Development

No branches or pull requests

2 participants