Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigureCustomDomain Only Supports One Domain #7143

Open
1 task done
AndrewBabbitt97 opened this issue Jan 17, 2025 · 0 comments
Open
1 task done

ConfigureCustomDomain Only Supports One Domain #7143

AndrewBabbitt97 opened this issue Jan 17, 2025 · 0 comments

Comments

@AndrewBabbitt97
Copy link

AndrewBabbitt97 commented Jan 17, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

ConfigureCustomDomain when called multiple times with different domains & parameters will override the last set domain.

Expected Behavior

When called multiple times, I would expect ConfigureCustomDomain to append the domain to the domain list instead of replace the list entirely.

Steps To Reproduce

Call ConfigureCustomDomain twice on the same container app, the second call will overwrite the first:

var builder = DistributedApplication.CreateBuilder(args);

var customDomain1 = builder.AddParameter("CustomDomain1");
var certificateName1 = builder.AddParameter("CertificateName1");
var customDomain2 = builder.AddParameter("CustomDomain2");
var certificateName2 = builder.AddParameter("CertificateName2");

builder.AddProject<Sample_Web>("web")
    .WithExternalHttpEndpoints()
    .PublishAsAzureContainerApp((module, app) =>
    {
        app.ConfigureCustomDomain(customDomain1, certificateName1);

        // This doesn't work
        app.ConfigureCustomDomain(customDomain2, certificateName2);
    });

builder.Build().Run();

Exceptions (if any)

N/A

.NET Version info

.NET SDK: 9.0.102
.NET Runtime: 9.0.1
.NET Aspire: 9.0.0

Anything else?

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant