Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Aspire is stuck on OpenTelemetry 1.9.0 #7123

Open
eerhardt opened this issue Jan 15, 2025 · 2 comments
Open

.NET Aspire is stuck on OpenTelemetry 1.9.0 #7123

eerhardt opened this issue Jan 15, 2025 · 2 comments
Labels
area-telemetry untriaged New issue has not been triaged

Comments

@eerhardt
Copy link
Member

We haven't updated our dependeny on OpenTelemetry past 1.9.0 because 1.10.0 introduces dependencies that "lift" assemblies out of the shared framework. See [bug] targets other than net9.0 shouldn't be forced to use 9.0 dependencies (open-telemetry/opentelemetry-dotnet#5973) for more information.

We should decide what to do with this dependency. The major consumer of these packages is our templates in the ServiceDefaults project.

  1. Should we upgrade to the new version even though we know it will "lift" Microsoft.Extensions.*, System.Diagnostics.DiagnosticsSource, • System.IO.Pipelines, System.Text.Encodings.Web, and System.Text.Json assemblies out of the shared framework?

  2. Should we stay on the 1.9.0 version, and customers can update to the new versions if they want?

  3. Should we split based on the TFM, and only use the new version if the app is targeting net9.0?

cc @joperezr @DamianEdwards @samsp-msft

@hdost
Copy link

hdost commented Jan 15, 2025

Might be worth talking to some of your coworkers about fixing the OTel upstream side 🤷‍♂️.

@joperezr joperezr added the untriaged New issue has not been triaged label Jan 17, 2025
@DamianEdwards
Copy link
Member

Should we split based on the TFM, and only use the new version if the app is targeting net9.0?

These seems like a reasonable thing to do as we can do it in the template source so new projects on net9.0 get OTel >1.9.0 and net8.0 gets 1.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-telemetry untriaged New issue has not been triaged
Projects
None yet
Development

No branches or pull requests

4 participants