Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapEntry in ClojureScript requires a third argument "__hash" #17

Open
w9 opened this issue Nov 10, 2020 · 3 comments
Open

MapEntry in ClojureScript requires a third argument "__hash" #17

w9 opened this issue Nov 10, 2020 · 3 comments

Comments

@w9
Copy link

w9 commented Nov 10, 2020

:cljs (cljs.core.MapEntry. key val)))

See https://cljs.github.io/api/cljs.core/MapEntry

Currently, the missing third argument gives a warning when compiled:

------ WARNING #1 - :fn-arity --------------------------------------------------
 Resource: tupelo/core.cljc:1200:12
 Wrong number of args (2) passed to cljs.core.MapEntry
--------------------------------------------------------------------------------
@cloojure
Copy link
Owner

Hmmm,

Looks like we could fix with this as the 3rd arg:

(hash-ordered-coll [key val])

???

@frenchy64
Copy link

Since __hash is mutable and filled in later, nil might work better as the 3rd arg.

https://github.com/clojure/clojurescript/blob/r1.10.891-1-g64435188/src/main/cljs/cljs/core.cljs#L2388

@frenchy64
Copy link

Or even (first {k v}) might be a portable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants