Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch-tags is not working according to the docs with v4 #1781

Open
64J0 opened this issue Jun 15, 2024 · 5 comments · May be fixed by #2039
Open

fetch-tags is not working according to the docs with v4 #1781

64J0 opened this issue Jun 15, 2024 · 5 comments · May be fixed by #2039

Comments

@64J0
Copy link

64J0 commented Jun 15, 2024

Hello, hope you're good. I'm running some experiments in order to build a custom action that demands the tags from the repo. I noticed that it was possible, in theory, just using the fetch-tags: true, but it does not work. I can only get the tags if I use the fetch-depth: 0.

Example workflow:

jobs:
  custom-action:
    runs-on: ubuntu-22.04
    steps:
      - name: Checkout repo
        uses: actions/checkout@v4
        with:
          path: tagaction
          fetch-tags: true
      - name: Try to get the tags
        run: |
          cd tagaction
          git tag --sort -creatordate

The last command (git tag --sort -creatordate) shows nothing in this case.

But, if I use the fetch-depth: 0, it lists correctly the tags from the repository.
@brandonsturgeon
Copy link

brandonsturgeon commented Jun 27, 2024 •
edited
Loading

I'm getting this too. I don't want to set fetch depth to 0.
It looks like git fetch --tags before running my commands works 👍

e: Looks like this still breaks if I use git describe --tags but that might be unrelated.

abxy added a commit to ReVibe-Energy/pyanura that referenced this issue Jul 5, 2024
@abxy
ci: Add fetch-depth: 0 as a workaround get tags on checkout
4ddcd81 
We should not be required to add this, but fetch-tags: true seems broken.
See actions/checkout#1781 for a second opinion,
and possible resolution.
abxy added a commit to ReVibe-Energy/pyanura that referenced this issue Jul 5, 2024
@abxy
ci: Add fetch-depth: 0 as a workaround get tags on checkout
b939b91 
We should not be required to add this, but fetch-tags: true seems broken.
See actions/checkout#1781 for a second opinion,
and possible resolution.
abxy added a commit to ReVibe-Energy/pyanura that referenced this issue Jul 11, 2024
@abxy
ci: Add fetch-depth: 0 as a workaround get tags on checkout
9fc6b00 
We should not be required to add this, but fetch-tags: true seems broken.
See actions/checkout#1781 for a second opinion,
and possible resolution.
nwiltsie added a commit to uclahs-cds/tool-create-release that referenced this issue Jul 29, 2024
@nwiltsie
fetch-tags does not work correctly
3187e7f 
actions/checkout#1781
@noonio noonio mentioned this issue Aug 16, 2024
Merged
4 tasks
jnikula added a commit to jnikula/hawkmoth that referenced this issue Sep 7, 2024
@jnikula
github: revert back to running git fetch --tags manually
422a41e 
checkout@v4 fetch-tags: true does not seem to work as expected
[1]. Version matrix ends up missing the tag for stable:

matrix={"include":[{"ref":"master","name":"dev"},{"ref":"","name":"stable"}]}

Work around this by reverting back to running git fetch --tags manually.

[1] actions/checkout#1781
@aol-nnov aol-nnov mentioned this issue Sep 18, 2024
Merged
@nerudaj
Copy link

nerudaj commented Sep 22, 2024

Still an issue.

@guettli
Copy link

guettli commented Oct 2, 2024 •
edited
Loading

The issue looks like this for us:

We are running 4.1.7 and use fetch-depth: 0, fetch-tags: true.

git tag -l lists all tags, except the tags we pushed (and which triggered our GithubAction for releasing).

We use git describe to detect the current git-tag. Since the pushed tag is not visible, our release process fails.

@csteenbock
Copy link

csteenbock commented Dec 2, 2024 •
edited
Loading

Also not working for me. I have fetch-tags: true, and it shows that in the action log, but the git command is not adding --tags like it should:

/opt/homebrew/bin/git -c protocol.version=2 fetch --prune --no-recurse-submodules --depth=1 origin +ab3c37e37b1bb41e6336a1f34d4f75f5706879af:refs/remotes/pull/193/merge

EDIT: You can see that they are not adding --tags in the fetch function here. I tried creating a branch to fix it, but I guess I don't have permission.

@totkeks
Copy link

totkeks commented Jan 4, 2025

I tried creating a branch to fix it, but I guess I don't have permission.

You need to create a fork of the repo first and then make a PR towards the original repo.

andreineculau added a commit to andreineculau/checkout that referenced this issue Jan 14, 2025
@andreineculau
fetch tags when fetch-depth > 0. fix actions#1781
0776c3a
@andreineculau andreineculau linked a pull request Jan 14, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fetch tags when fetch-depth > 0. fix #1781 andreineculau/checkout
6 participants
@guettli @totkeks @brandonsturgeon @nerudaj @64J0 @csteenbock