New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to factorize mcpc 1.9 -> 1.16 #92

Open

rom1504 opened this issue Jun 29, 2020 · 1 comment

Labels

Member

rom1504 commented Jun 29, 2020

with a few well placed if and the supportFeature pattern, it might work and remove lot of code duplication

Member Author

rom1504 commented Aug 7, 2021

to put in common all the chunk section and all the chunk column, we'd need a file like https://github.com/PrismarineJS/mineflayer/blob/master/lib/features.json ; put in it features that look like https://github.com/PrismarineJS/prismarine-chunk/pull/125/files#diff-a561630bb56b82342bc66697aee2ad96efddcbc9d150665abd6fb7ecb7c0ab2fR23 and then add ifs like https://github.com/PrismarineJS/mineflayer/blob/475bb268fa416b45b1a200e79549df0144a6212e/lib/plugins/game.js#L31
that should be fairly straightforward to do, pretty mecanical, just a bit long

rom1504 added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment