New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaletteStorage.incrementPalette can go out of bounds #183

Open

lowlines opened this issue May 28, 2022 · 1 comment

lowlines commented May 28, 2022

prismarine-chunk/src/bedrock/common/PalettedStorage.js

Lines 95 to 102 in 0f4ec64

    
           incrementPalette (palette) { 
        
             for (let i = 0; i < this.wordsCount; i++) { 
        
               for (let j = 0; j < this.blocksPerWord; j++) { 
        
                 const ix = this.readBits(i, j * this.bitsPerBlock) 
        
                 palette[ix].count++ 
        
               } 
        
             } 
        
           }

If you have bitsPerBlock size that causes rounding on the wordCount, this double for loop will go beyond the 4096 block range and throw and error.

Member

extremeheat commented Jun 4, 2022

Please open PR if you have a fix.

lowlines mentioned this issue

PaletteStorage.incrementPalette fix #184

Closed

extremeheat mentioned this issue

Bedrock 1.19.1 support, fix pc 1.18 world height loading from disk #206

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment