Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: change from anti-pattern passing of external state #457

Open
pearsonca opened this issue Jan 8, 2025 · 0 comments
Open

[Bug]: change from anti-pattern passing of external state #457

pearsonca opened this issue Jan 8, 2025 · 0 comments
Labels
enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. low priority Low priority.
Milestone
Software Quality

Comments

@pearsonca
Copy link
Contributor

pearsonca commented Jan 8, 2025 •
edited
Loading

Label

dependency

Priority Label

low priority

Describe the bug/issue

Several places in the code adopt the anti-pattern of passing in a parsed string of caller-state to a method for error-messaging (e.g., in compartment.get_comp_idx

Desired Refactor

We should instead be using a try-catch or option pattern for these methods and their callers.
@TimothyWillard TimothyWillard added enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. low priority Low priority. labels Jan 10, 2025
@TimothyWillard TimothyWillard added this to the Software Quality milestone Jan 10, 2025
@TimothyWillard TimothyWillard changed the title [Refactor]: change from anti-pattern passing of external state [Bug]: change from anti-pattern passing of external state Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. low priority Low priority.
Projects
None yet
Milestone
Software Quality
Development

No branches or pull requests
2 participants
@pearsonca @TimothyWillard