Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unqualified !cubeinfo in unusual places can be surprising #3

Open
robsiemb opened this issue Oct 2, 2024 · 0 comments
Open

Unqualified !cubeinfo in unusual places can be surprising #3

robsiemb opened this issue Oct 2, 2024 · 0 comments
Labels
cube Related to cubes enhancement New feature or request good first issue Good for newcomers slack Slack Specific

Comments

@robsiemb
Copy link
Contributor

robsiemb commented Oct 2, 2024

Currently !cubeinfo (with no provided cube number) will return the most recent cube's data. However, this can be confusing if you issue !cubeinfo in a thread where an onder cube was sent (especially so on the public cube channel). You probably expect to get the info for that cube (especially for automatic cubes).

Since we only track the most recent cube (and, really, we don't want to keep around an unbounded number of cube number to thread mappings), we may need to modify the behavior to be closer to how !cuberocks and !cubesucks work. That is, allow it only in the channel/thread of the most recent cube. (There is already some code to fail if we issue a !cubeinfo and it might return data for a cube that was sent to a private channel to avoid leaking that information).

Qualified (that is, with a provided cube number) !cubeinfo can remain unaffected, of course, as it doesn't rely in automatically determining the cube to describe.

@robsiemb robsiemb added enhancement New feature or request good first issue Good for newcomers cube Related to cubes slack Slack Specific labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cube Related to cubes enhancement New feature or request good first issue Good for newcomers slack Slack Specific
Projects
None yet
Development

No branches or pull requests

1 participant